Draft
Conversation
Co-authored-by: RyanCavanaugh <[email protected]>
Co-authored-by: RyanCavanaugh <[email protected]>
Co-authored-by: RyanCavanaugh <[email protected]>
Co-authored-by: RyanCavanaugh <[email protected]>
Copilot
AI
changed the title
[WIP] JSX comment duplicated
Fix JSX comment duplication in preserve mode
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where comments adjacent to JSX expressions were duplicated in the emitted output when using
jsx: preservemode.Problem
When JSX contains comments immediately before or after expressions, TypeScript was emitting those comments twice:
Root Cause
The issue occurred because comments in JSX content are parsed as both:
JsxTextwith content"/*pre*/")This caused the same comment content to be emitted twice:
emitJsxText()emitTokenWithComment()Solution
The fix prevents duplicate comment emission by:
isEmittingJsxChildrenflag to track when we're emitting JSX element childrenemitTokenWithComment()to skip leading/trailing comment emission for JSX expressions when they would duplicate JSX text contentTesting
Added comprehensive test case covering:
<div>/*pre*/{x}/*post*/</div><App>/* no */{/* 1 */ 123 /* 2 */}/* no */</App>The fix works for both
jsx: preserveandjsx: react-jsxdevmodes.Addressing #11.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.